Skip to content

feat(langchain): Support v1 #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 23, 2025
Merged

feat(langchain): Support v1 #4874

merged 12 commits into from
Oct 23, 2025

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 29, 2025 •
edited
Loading

Description

Adapt to import changes in new langchain 1.x

Issues

Closes #4735

Reminders

@codecov
Copy link

codecov bot commented Sep 29, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
27447 2 27445 2004
View the full list of 2 ❄️ flaky test(s) 
tests.profiler.test_continuous_profiler::test_continuous_profiler_auto_start_and_manual_stop[non-experiment-start_profile_session/stop_profile_session (deprecated)-gevent]

Flake rate in main: 61.70% (Passed 18 times, Failed 29 times)

Stack Traces | 0.555s run time 
tests/profiler/test_continuous_profiler.py:291: in test_continuous_profiler_auto_start_and_manual_stop
    assert_single_transaction_with_profile_chunks(envelopes, thread)
tests/profiler/test_continuous_profiler.py:147: in assert_single_transaction_with_profile_chunks
    assert len(items["profile_chunk"]) > 0
E   assert 0 > 0
E    +  where 0 = len([])
tests.profiler.test_continuous_profiler::test_continuous_profiler_auto_start_and_manual_stop[non-experiment-start_profiler/stop_profiler-gevent]

Flake rate in main: 61.70% (Passed 18 times, Failed 29 times)

Stack Traces | 0.548s run time 
tests/profiler/test_continuous_profiler.py:291: in test_continuous_profiler_auto_start_and_manual_stop
    assert_single_transaction_with_profile_chunks(envelopes, thread)
tests/profiler/test_continuous_profiler.py:147: in assert_single_transaction_with_profile_chunks
    assert len(items["profile_chunk"]) > 0
E   assert 0 > 0
E    +  where 0 = len([])

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana mentioned this pull request Oct 2, 2025
Closed
@sentrivana sentrivana marked this pull request as ready for review October 23, 2025 07:14
@sentrivana sentrivana requested a review from a team as a code owner October 23, 2025 07:14
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: AgentExecutor Import Overwrite Bug

The AgentExecutor import logic has two sequential try/except blocks. The second block unconditionally executes, causing langchain.agents.AgentExecutor to overwrite a successful langchain_classic.agents.AgentExecutor import (intended for v1+). This also means a successful langchain_classic import is lost if the langchain import fails, incorrectly setting AgentExecutor to None.

Fix in Cursor Fix in Web

seer-by-sentry[bot]
seer-by-sentry bot reviewed Oct 23, 2025
View reviewed changes
emieldatalytica
emieldatalytica suggested changes Oct 23, 2025
View reviewed changes
@sentrivana sentrivana enabled auto-merge (squash) October 23, 2025 08:46
@sentrivana sentrivana merged commit 3d026cd into master Oct 23, 2025
128 of 130 checks passed
@sentrivana sentrivana deleted the ivana/support-langchain-v1 branch October 23, 2025 08:58
shellmayr pushed a commit that referenced this pull request Oct 30, 2025
@sentrivana @shellmayr
feat(langchain): Support v1 (#4874)
4a44dfc 
### Description
Adapt to import changes in new langchain 1.x

#### Issues
Closes #4735

#### Reminders
- Please add tests to validate your changes, and lint your code using
`tox -e linters`.
- Add GH Issue ID _&_ Linear ID (if applicable)
- PR title should use [conventional
commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type)
style (`feat:`, `fix:`, `ref:`, `meta:`)
- For external contributors:
[CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md),
[Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord
community](https://discord.gg/Ww9hbqr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

+1 more reviewer

@emieldatalytica emieldatalytica emieldatalytica requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support langchain v1.0

4 participants

@sentrivana @emieldatalytica @alexander-alderman-webb